Conversation
Deploying with
|
| Latest commit: |
21448ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4be73686.graphite.pages.dev |
| Branch Preview URL: | https://layer-thumbnails.graphite.pages.dev |
✅ Deploy Preview ready!
|
5 tasks
nat-rix
reviewed
May 15, 2023
nat-rix
reviewed
May 15, 2023
nat-rix
reviewed
May 15, 2023
nat-rix
reviewed
May 15, 2023
Keavon
reviewed
May 18, 2023
| let uuid = generate_uuid(); | ||
| render.svg.push(SvgSegment::BlobUrl(uuid)); | ||
| render.svg.push("\" />".into()); | ||
| render.image_data.push((uuid, self.image.clone())) |
Member
There was a problem hiding this comment.
ChatGPT recommends this, is it applicable?
Keavon
approved these changes
May 18, 2023
Member
Keavon
left a comment
Keavon
left a comment
There was a problem hiding this comment.
Looks fantastic. Merging this now. Feel free to check out and respond to the one comment I left if it's relevant.
TrueDoctor
pushed a commit
that referenced
this pull request
May 23, 2023
* Thumbnails for the layer node * Raster node graph frames * Downscale to a random resolution * Cleanup and bug fixes * Generate paths before duplicating outputs * Fix stable id test * Code review changes * Code review pass with minor changes --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
Keavon
added a commit
that referenced
this pull request
Jul 30, 2023
* Thumbnails for the layer node * Raster node graph frames * Downscale to a random resolution * Cleanup and bug fixes * Generate paths before duplicating outputs * Fix stable id test * Code review changes * Code review pass with minor changes --------- Co-authored-by: Keavon Chambers <keavon@keavon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1211
Thumbnails in the node graph - building on TrueDoctor's node graph introspection mechanism.
ToDo:
Styling as part of #1175